[Box Backup-dev] Re: [Box Backup] ChrisMerge_1828

James O'Gorman boxbackup-dev at fluffy.co.uk
Fri Sep 14 22:05:40 BST 2007


On Fri, Sep 14, 2007 at 09:55:00PM +0100, Chris Wilson wrote:
>  Looks great to me. Maybe worth sending the details of the message type to 
>  the log as well?

Meaning "store-full", "read-error" or "unknown"? (i.e. the arguments
passed to the script.)

>  Also, I reckon it should be:
> 
>  * an error if the message was not sent; otherwise
>  * nothing if the message was "backup-start" or "backup-finish"; or

The script currently only checks for the three above, as per the sh
version so it won't anyway. Is there anything else that needs to be
checked for?

>  * a warning otherwise.

OK, I'll do that.

James



More information about the Boxbackup-dev mailing list