From boxbackup-dev at fluffy.co.uk Sun Jun 15 22:22:58 2008 From: boxbackup-dev at fluffy.co.uk (James O'Gorman) Date: Sun, 15 Jun 2008 22:22:58 +0100 Subject: [Box Backup-dev] Re: [Box Backup-commit] COMMIT r2191 - box/trunk/contrib/debian In-Reply-To: <20080615190832.05816326CDA@www.boxbackup.org> References: <20080615190832.05816326CDA@www.boxbackup.org> Message-ID: <48558832.60609@netinertia.co.uk> subversion at fluffy.co.uk wrote: > Modified: box/trunk/contrib/debian/bbackupd.in > =================================================================== > --- box/trunk/contrib/debian/bbackupd.in 2008-05-29 21:51:38 UTC (rev 2190) > +++ box/trunk/contrib/debian/bbackupd.in 2008-06-15 19:08:30 UTC (rev 2191) > @@ -4,7 +4,7 @@ > > BBACKUPD=@sbindir_expanded@/bbackupd > CONFIG=@sysconfdir_expanded@/box/bbackupd.conf > -PIDFILE=@localstatedir_expanded@/bbackupd.pid > +PIDFILE=@localstatedir_expanded@/bbackupd/bbackupd.pid Should that not be run/bbackupd.pid (as per bbstored below)? > Modified: box/trunk/contrib/debian/bbstored.in > =================================================================== > --- box/trunk/contrib/debian/bbstored.in 2008-05-29 21:51:38 UTC (rev 2190) > +++ box/trunk/contrib/debian/bbstored.in 2008-06-15 19:08:30 UTC (rev 2191) > @@ -4,7 +4,7 @@ > > BBSTORED=@sbindir_expanded@/bbstored > CONFIG=@sysconfdir_expanded@/box/bbstored.conf > -PIDFILE=@localstatedir_expanded@/bbstored.pid > +PIDFILE=@localstatedir_expanded@/run/bbstored.pid James From boxbackup-dev at fluffy.co.uk Sun Jun 15 22:28:00 2008 From: boxbackup-dev at fluffy.co.uk (Chris Wilson) Date: Sun, 15 Jun 2008 22:28:00 +0100 (BST) Subject: [Box Backup-dev] Re: [Box Backup-commit] COMMIT r2191 - box/trunk/contrib/debian In-Reply-To: <48558832.60609@netinertia.co.uk> References: <20080615190832.05816326CDA@www.boxbackup.org> <48558832.60609@netinertia.co.uk> Message-ID: Hi James, On Sun, 15 Jun 2008, James O'Gorman wrote: > > BBACKUPD=@sbindir_expanded@/bbackupd > > CONFIG=@sysconfdir_expanded@/box/bbackupd.conf > > -PIDFILE=@localstatedir_expanded@/bbackupd.pid > > +PIDFILE=@localstatedir_expanded@/bbackupd/bbackupd.pid > > Should that not be run/bbackupd.pid (as per bbstored below)? Well spotted, but the default for bbackupd-config, as far as I can tell, is to place all run-state files, including the PID file, in /var/bbackupd. If users choose a different directory for running state than the recommended one, or change the PidFile in bbackupd.conf, then they will have to hack their initscripts to match. I thought about changing the default location of the PID file to be @localstatedir_expanded@/run, but that would break backwards compatibility. I'm not averse to doing that for 0.11 release if people want it, but I didn't want to just go ahead and do it without feedback from people. So, people, if you'd prefer your bbackupd PID file in /var/run or /var/bbackupd, please let me know :-) Cheers, Chris. -- _____ __ _ \ __/ / ,__(_)_ | Chris Wilson <0000 at qwirx.com> - Cambs UK | / (_/ ,\/ _/ /_ \ | Security/C/C++/Java/Ruby/Perl/SQL Developer | \ _/_/_/_//_/___/ | We are GNU : free your mind & your software | From boxbackup-dev at fluffy.co.uk Sun Jun 15 22:35:17 2008 From: boxbackup-dev at fluffy.co.uk (James O'Gorman) Date: Sun, 15 Jun 2008 22:35:17 +0100 Subject: [Box Backup-dev] Re: [Box Backup-commit] COMMIT r2191 - box/trunk/contrib/debian In-Reply-To: References: <20080615190832.05816326CDA@www.boxbackup.org> <48558832.60609@netinertia.co.uk> Message-ID: <48558B15.7070108@netinertia.co.uk> Chris Wilson wrote: > Well spotted, but the default for bbackupd-config, as far as I can tell, > is to place all run-state files, including the PID file, in /var/bbackupd. Ah, OK, fair enough. > If users choose a different directory for running state than the > recommended one, or change the PidFile in bbackupd.conf, then they will > have to hack their initscripts to match. Well, I wrote the FreeBSD script so... :-) If you think it'll be deviating from other distributions' scripts though, let me know and I'll change it. > I thought about changing the default location of the PID file to be > @localstatedir_expanded@/run, but that would break backwards > compatibility. I'm not averse to doing that for 0.11 release if people > want it, but I didn't want to just go ahead and do it without feedback > from people. I must admit, my config has been sitting there happily for a few years now so I've forgotten what the default are; I have CommandSocket and PidFile set to /var/run/bbackupd.{sock,pid}, but I'm also awkward and have the DataDirectory under /data/bbackupd :-) James From boxbackup-dev at fluffy.co.uk Sun Jun 15 22:42:09 2008 From: boxbackup-dev at fluffy.co.uk (Chris Wilson) Date: Sun, 15 Jun 2008 22:42:09 +0100 (BST) Subject: [Box Backup-dev] Re: [Box Backup-commit] COMMIT r2191 - box/trunk/contrib/debian In-Reply-To: <48558B15.7070108@netinertia.co.uk> References: <20080615190832.05816326CDA@www.boxbackup.org> <48558832.60609@netinertia.co.uk> <48558B15.7070108@netinertia.co.uk> Message-ID: Hi James, On Sun, 15 Jun 2008, James O'Gorman wrote: > > If users choose a different directory for running state than the > > recommended one, or change the PidFile in bbackupd.conf, then they > > will have to hack their initscripts to match. > > Well, I wrote the FreeBSD script so... :-) If you think it'll be > deviating from other distributions' scripts though, let me know and I'll > change it. Not sure exactly what you mean here. Does your freebsd initscript expect the bbackupd.pid file in /var/run or similar? If so, then I reckon it might be wrong (or at least inconsistent with bbackupd-config). I think /var/run is the "most common" (not to say official) place for PID files, and therefore technically or arguably "right", but I think we have to accept that almost all current users will have their bbackupd.pid in their running state directory, and I don't want to break compatibility without a vote of confidence. > I must admit, my config has been sitting there happily for a few years > now so I've forgotten what the default are; I have CommandSocket and > PidFile set to /var/run/bbackupd.{sock,pid}, but I'm also awkward and > have the DataDirectory under /data/bbackupd :-) Check out bbackupd-config if in doubt :-) Cheers, Chris. -- _____ __ _ \ __/ / ,__(_)_ | Chris Wilson <0000 at qwirx.com> - Cambs UK | / (_/ ,\/ _/ /_ \ | Security/C/C++/Java/Ruby/Perl/SQL Developer | \ _/_/_/_//_/___/ | We are GNU : free your mind & your software | From boxbackup-dev at fluffy.co.uk Mon Jun 16 17:50:21 2008 From: boxbackup-dev at fluffy.co.uk (James O'Gorman) Date: Mon, 16 Jun 2008 17:50:21 +0100 Subject: [Box Backup-dev] Re: [Box Backup-commit] COMMIT r2191 - box/trunk/contrib/debian In-Reply-To: References: <20080615190832.05816326CDA@www.boxbackup.org> <48558832.60609@netinertia.co.uk> <48558B15.7070108@netinertia.co.uk> Message-ID: <485699CD.1080303@netinertia.co.uk> Chris Wilson wrote: > Hi James, > > On Sun, 15 Jun 2008, James O'Gorman wrote: > >>> If users choose a different directory for running state than the >>> recommended one, or change the PidFile in bbackupd.conf, then they >>> will have to hack their initscripts to match. >> Well, I wrote the FreeBSD script so... :-) If you think it'll be >> deviating from other distributions' scripts though, let me know and I'll >> change it. > > Not sure exactly what you mean here. Does your freebsd initscript expect > the bbackupd.pid file in /var/run or similar? Correct. > If so, then I reckon it might be wrong (or at least inconsistent with > bbackupd-config). I suspect that happened because I configured bbackupd first and then created the port. I'll fix that when I update the port for 0.11. > I think /var/run is the "most common" (not to say official) place for PID > files, and therefore technically or arguably "right", but I think we have > to accept that almost all current users will have their bbackupd.pid in > their running state directory, and I don't want to break compatibility > without a vote of confidence. That's fair. James