From trac at boxbackup.org Sat Oct 4 12:00:00 2014 From: trac at boxbackup.org (trac at boxbackup.org) Date: Sat, 4 Oct 2014 12:00:00 +0100 (BST) Subject: [Boxbackup-dev] Current open tickets Message-ID: <201410041100.s94B00sp003654@wm.boxbackup.org> Note: to view an indiviual ticket, use: https://www.boxbackup.org/trac/ticket/(number) The following is a listing of current problems submitted by Box Backup users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Ticket Owner Component Summary - ------ ------ ------------- ------------------------------------------------------------ n 4 martin box libraries Port Box Backup to AIX n 6 box libraries Contribute code: SMTP client, HTTP server, Database drivers, n 7 box libraries Improve restore speed on local repositories n 8 chris box libraries Improve handling of directories with many files n 13 chris bbackupd Fix file locking on Windows n 14 chris bbackupd Fix large file issues on Windows n 16 chris bbackupquery Restore deleted directories may fail a 17 chris bbackupquery List files using wildcards a 20 chris bbackupctl bbackupctl reload reports prior settings n 45 ben bbackupd File diff performance patch (reduced disk IO and wall time n 46 chris bbackupd bbackupd only ever saves reverse diffs, corrupted files on s n 47 chris bbackupd Account numbers greater than 2^31 (0x7fffffff) do not work c n 48 chris bbackupd Locations that don't exist on first run are never tried agai n 49 chris bbackupd ID map (rename tracking) broken since [288] n 50 chris bbackupquery No way to capture stderr under Windows n 51 chris bbackupd No way to force bbackupd to re-upload files under Windows n 52 chris bbackupd Unable to control the maintenance of old vs. deleted files n 53 chris bbackupd Comparing root directory locations does not work under Windo n 54 chris bbackupd Locations not found on disk (e.g. unmounted filesystems) can n 55 chris bbackupd Should store and preserve directory timestamps n 56 bbackupquery Windows: User can polute restore directory by adding a trail n 57 ben bbackupd Create boxbackupresume and other files in DataDirectory n 58 ben bbackupd bbackupquery connection timeout results in error message, sh n 59 ben bbackupd Inconsistent treatment of NotifyScript between Box Backup an n 60 ben bbstored Case sensitivity between bbstored-certs and Boxi n 62 ben bbackupd Backups of deleted files may be removed very quickly by hous a 63 chris bbackupd Support hard links in directories n 65 ben bbackupd Some file attributes under Windows are not backed up n 66 ben bbackupd Windows ACL support a 67 chris bbackupd Add mutexes for Win32 (client) to enable detection of runnin n 68 ben bbackupd More details when ReadError occurs n 69 bbackupquery CRTL+C closes bbackupquery console window under Windows n 70 ben bbackupd Non-ascii character cause error for notifyscript path n 71 ben bbackupd bbackupd.log gets randomly deleted n 72 test suite Patch intercept.h and intercept.c for NetBSD 4 and 5 n 74 bbackupquery Reconnect bbackupquery automatically, or at least have a "co n 75 ben bbackupd Restore times wrong, times on store correct n 77 ben bbackupd Min verbosity switch broken for bbackupquery a 78 chris bbackupd Error level for "bbackupquery.exe -u" 39 tickets total. From Kai.Liebenau at gmx.net Thu Oct 9 20:35:44 2014 From: Kai.Liebenau at gmx.net (Kai Liebenau) Date: Thu, 09 Oct 2014 21:35:44 +0200 Subject: [Boxbackup-dev] current trunk In-Reply-To: References: <53E64473.50908@gmx.net> Message-ID: <5436E390.9090107@gmx.net> Hi Chris, i have some bugs found in the svn-trunk tree. I missed the getopt.h file, but in the browser trunk tree is it present. Now then the WinNamedPipeStream.cpp file have some incorrect definition. Here is the patch for them. In the file Daemon.cpp is missing one include for Win32. I have added this and now i can compile it. For the ticket #69 "CRTL+C closes bbackupquery console window under Windows", i have some modification. The current handler ignore the Ctrl+C and Ctrl Colse Events. I don't knowing were i can interrupt the current action. Cheers Kai -------------- next part -------------- Index: WinNamedPipeStream.cpp =================================================================== --- WinNamedPipeStream.cpp (revision 3412) +++ WinNamedPipeStream.cpp (working copy) @@ -91,7 +91,7 @@ GetErrorMessage(err)); Close(); THROW_EXCEPTION(ConnectionException, - Conn_SocketReadError) + SocketReadError) } } } @@ -334,7 +334,7 @@ Close(); THROW_EXCEPTION(ConnectionException, - Conn_SocketReadError) + SocketReadError) } } } @@ -394,7 +394,7 @@ << GetErrorMessage(err)); Close(); THROW_EXCEPTION(ConnectionException, - Conn_SocketReadError) + SocketReadError) } } } @@ -424,7 +424,7 @@ BOX_ERROR("Failed to read from control socket: " << GetErrorMessage(err)); THROW_EXCEPTION(ConnectionException, - Conn_SocketReadError) + SocketReadError) } } @@ -486,7 +486,7 @@ Close(); THROW_EXCEPTION(ConnectionException, - Conn_SocketWriteError) + SocketWriteError) } NumBytesWrittenTotal += NumBytesWrittenThisTime; -------------- next part -------------- Index: Daemon.cpp =================================================================== --- Daemon.cpp (revision 3412) +++ Daemon.cpp (working copy) @@ -24,6 +24,7 @@ #endif #ifdef WIN32 + #include #include #include #endif -------------- next part -------------- Index: bbackupquery.cpp =================================================================== --- bbackupquery.cpp (revision 3412) +++ bbackupquery.cpp (working copy) @@ -181,6 +181,36 @@ #endif // HAVE_LIBREADLINE +#ifdef WIN32 +// Ticket #69, CRTL+C closes bbackupquery console window under Windows +BOOL Win32CtrlHandler(DWORD dwCtrlType) +{ + BOOL isHandled = FALSE; + + switch(dwCtrlType) + { + case CTRL_C_EVENT: // interrupting the current action + BOX_INFO("Ctrl-C event"); + isHandled = TRUE; + break; + case CTRL_BREAK_EVENT: // interrupting the current action also? + BOX_INFO("Break event"); + break; + case CTRL_CLOSE_EVENT: // interrupting the current action ,logoff from store and exit process + BOX_INFO("Close event"); + isHandled = TRUE; + break; + case CTRL_LOGOFF_EVENT: // interrupting the current action ,logoff from store and exit process + BOX_INFO("Logoff event"); + break; + case CTRL_SHUTDOWN_EVENT: // interrupting the current action ,logoff from store and exit process + BOX_INFO("Shutdown event"); + break; + } + return isHandled; +} +#endif + int main(int argc, const char *argv[]) { int returnCode = 0; @@ -407,6 +437,14 @@ BOX_INFO("Login complete."); BOX_INFO("Type \"help\" for a list of commands."); + // install the CtrlHandler to interrupt the running action +#ifdef WIN32 + if(SetConsoleCtrlHandler((PHANDLER_ROUTINE)Win32CtrlHandler,TRUE) != TRUE) + { + BOX_ERROR("Faild to install CtrlHandler: " << + GetErrorMessage(GetLastError())); + } +#endif // Set up a context for our work BackupQueries context(connection, conf, readWrite); @@ -512,7 +550,15 @@ } #endif // HAVE_READLINE_HISTORY } - + // uninstall the CtrlHandler to cleanup +#ifdef WIN32 + if(SetConsoleCtrlHandler((PHANDLER_ROUTINE)Win32CtrlHandler,FALSE) != TRUE) + { + BOX_ERROR("Faild to uninstall CtrlHandler: " << + GetErrorMessage(GetLastError())); + } +#endif + // Done... stop nicely BOX_INFO("Logging off..."); connection.QueryFinished(); From trac at boxbackup.org Sat Oct 11 12:00:01 2014 From: trac at boxbackup.org (trac at boxbackup.org) Date: Sat, 11 Oct 2014 12:00:01 +0100 (BST) Subject: [Boxbackup-dev] Current open tickets Message-ID: <201410111100.s9BB00P9065179@wm.boxbackup.org> Note: to view an indiviual ticket, use: https://www.boxbackup.org/trac/ticket/(number) The following is a listing of current problems submitted by Box Backup users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Ticket Owner Component Summary - ------ ------ ------------- ------------------------------------------------------------ n 4 martin box libraries Port Box Backup to AIX n 6 box libraries Contribute code: SMTP client, HTTP server, Database drivers, n 7 box libraries Improve restore speed on local repositories n 8 chris box libraries Improve handling of directories with many files n 13 chris bbackupd Fix file locking on Windows n 14 chris bbackupd Fix large file issues on Windows n 16 chris bbackupquery Restore deleted directories may fail a 17 chris bbackupquery List files using wildcards a 20 chris bbackupctl bbackupctl reload reports prior settings n 45 ben bbackupd File diff performance patch (reduced disk IO and wall time n 46 chris bbackupd bbackupd only ever saves reverse diffs, corrupted files on s n 47 chris bbackupd Account numbers greater than 2^31 (0x7fffffff) do not work c n 48 chris bbackupd Locations that don't exist on first run are never tried agai n 49 chris bbackupd ID map (rename tracking) broken since [288] n 50 chris bbackupquery No way to capture stderr under Windows n 51 chris bbackupd No way to force bbackupd to re-upload files under Windows n 52 chris bbackupd Unable to control the maintenance of old vs. deleted files n 53 chris bbackupd Comparing root directory locations does not work under Windo n 54 chris bbackupd Locations not found on disk (e.g. unmounted filesystems) can n 55 chris bbackupd Should store and preserve directory timestamps n 56 bbackupquery Windows: User can polute restore directory by adding a trail n 57 ben bbackupd Create boxbackupresume and other files in DataDirectory n 58 ben bbackupd bbackupquery connection timeout results in error message, sh n 59 ben bbackupd Inconsistent treatment of NotifyScript between Box Backup an n 60 ben bbstored Case sensitivity between bbstored-certs and Boxi n 62 ben bbackupd Backups of deleted files may be removed very quickly by hous a 63 chris bbackupd Support hard links in directories n 65 ben bbackupd Some file attributes under Windows are not backed up n 66 ben bbackupd Windows ACL support a 67 chris bbackupd Add mutexes for Win32 (client) to enable detection of runnin n 68 ben bbackupd More details when ReadError occurs n 69 bbackupquery CRTL+C closes bbackupquery console window under Windows n 70 ben bbackupd Non-ascii character cause error for notifyscript path n 71 ben bbackupd bbackupd.log gets randomly deleted n 72 test suite Patch intercept.h and intercept.c for NetBSD 4 and 5 n 74 bbackupquery Reconnect bbackupquery automatically, or at least have a "co n 75 ben bbackupd Restore times wrong, times on store correct n 77 ben bbackupd Min verbosity switch broken for bbackupquery a 78 chris bbackupd Error level for "bbackupquery.exe -u" 39 tickets total. From trac at boxbackup.org Sat Oct 18 12:00:02 2014 From: trac at boxbackup.org (trac at boxbackup.org) Date: Sat, 18 Oct 2014 12:00:02 +0100 (BST) Subject: [Boxbackup-dev] Current open tickets Message-ID: <201410181100.s9IB026g022675@wm.boxbackup.org> Note: to view an indiviual ticket, use: https://www.boxbackup.org/trac/ticket/(number) The following is a listing of current problems submitted by Box Backup users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Ticket Owner Component Summary - ------ ------ ------------- ------------------------------------------------------------ n 4 martin box libraries Port Box Backup to AIX n 6 box libraries Contribute code: SMTP client, HTTP server, Database drivers, n 7 box libraries Improve restore speed on local repositories n 8 chris box libraries Improve handling of directories with many files n 13 chris bbackupd Fix file locking on Windows n 14 chris bbackupd Fix large file issues on Windows n 16 chris bbackupquery Restore deleted directories may fail a 17 chris bbackupquery List files using wildcards a 20 chris bbackupctl bbackupctl reload reports prior settings n 45 ben bbackupd File diff performance patch (reduced disk IO and wall time n 46 chris bbackupd bbackupd only ever saves reverse diffs, corrupted files on s n 47 chris bbackupd Account numbers greater than 2^31 (0x7fffffff) do not work c n 48 chris bbackupd Locations that don't exist on first run are never tried agai n 49 chris bbackupd ID map (rename tracking) broken since [288] n 50 chris bbackupquery No way to capture stderr under Windows n 51 chris bbackupd No way to force bbackupd to re-upload files under Windows n 52 chris bbackupd Unable to control the maintenance of old vs. deleted files n 53 chris bbackupd Comparing root directory locations does not work under Windo n 54 chris bbackupd Locations not found on disk (e.g. unmounted filesystems) can n 55 chris bbackupd Should store and preserve directory timestamps n 56 bbackupquery Windows: User can polute restore directory by adding a trail n 57 ben bbackupd Create boxbackupresume and other files in DataDirectory n 58 ben bbackupd bbackupquery connection timeout results in error message, sh n 59 ben bbackupd Inconsistent treatment of NotifyScript between Box Backup an n 60 ben bbstored Case sensitivity between bbstored-certs and Boxi n 62 ben bbackupd Backups of deleted files may be removed very quickly by hous a 63 chris bbackupd Support hard links in directories n 65 ben bbackupd Some file attributes under Windows are not backed up n 66 ben bbackupd Windows ACL support a 67 chris bbackupd Add mutexes for Win32 (client) to enable detection of runnin n 68 ben bbackupd More details when ReadError occurs n 69 bbackupquery CRTL+C closes bbackupquery console window under Windows n 70 ben bbackupd Non-ascii character cause error for notifyscript path n 71 ben bbackupd bbackupd.log gets randomly deleted n 72 test suite Patch intercept.h and intercept.c for NetBSD 4 and 5 n 74 bbackupquery Reconnect bbackupquery automatically, or at least have a "co n 75 ben bbackupd Restore times wrong, times on store correct n 77 ben bbackupd Min verbosity switch broken for bbackupquery a 78 chris bbackupd Error level for "bbackupquery.exe -u" 39 tickets total. From trac at boxbackup.org Sat Oct 25 12:00:00 2014 From: trac at boxbackup.org (trac at boxbackup.org) Date: Sat, 25 Oct 2014 12:00:00 +0100 (BST) Subject: [Boxbackup-dev] Current open tickets Message-ID: <201410251100.s9PB00AL077558@wm.boxbackup.org> Note: to view an indiviual ticket, use: https://www.boxbackup.org/trac/ticket/(number) The following is a listing of current problems submitted by Box Backup users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Ticket Owner Component Summary - ------ ------ ------------- ------------------------------------------------------------ n 4 martin box libraries Port Box Backup to AIX n 6 box libraries Contribute code: SMTP client, HTTP server, Database drivers, n 7 box libraries Improve restore speed on local repositories n 8 chris box libraries Improve handling of directories with many files n 13 chris bbackupd Fix file locking on Windows n 14 chris bbackupd Fix large file issues on Windows n 16 chris bbackupquery Restore deleted directories may fail a 17 chris bbackupquery List files using wildcards a 20 chris bbackupctl bbackupctl reload reports prior settings n 45 ben bbackupd File diff performance patch (reduced disk IO and wall time n 46 chris bbackupd bbackupd only ever saves reverse diffs, corrupted files on s n 47 chris bbackupd Account numbers greater than 2^31 (0x7fffffff) do not work c n 48 chris bbackupd Locations that don't exist on first run are never tried agai n 49 chris bbackupd ID map (rename tracking) broken since [288] n 50 chris bbackupquery No way to capture stderr under Windows n 51 chris bbackupd No way to force bbackupd to re-upload files under Windows n 52 chris bbackupd Unable to control the maintenance of old vs. deleted files n 53 chris bbackupd Comparing root directory locations does not work under Windo n 54 chris bbackupd Locations not found on disk (e.g. unmounted filesystems) can n 55 chris bbackupd Should store and preserve directory timestamps n 56 bbackupquery Windows: User can polute restore directory by adding a trail n 57 ben bbackupd Create boxbackupresume and other files in DataDirectory n 58 ben bbackupd bbackupquery connection timeout results in error message, sh n 59 ben bbackupd Inconsistent treatment of NotifyScript between Box Backup an n 60 ben bbstored Case sensitivity between bbstored-certs and Boxi n 62 ben bbackupd Backups of deleted files may be removed very quickly by hous a 63 chris bbackupd Support hard links in directories n 65 ben bbackupd Some file attributes under Windows are not backed up n 66 ben bbackupd Windows ACL support a 67 chris bbackupd Add mutexes for Win32 (client) to enable detection of runnin n 68 ben bbackupd More details when ReadError occurs n 69 bbackupquery CRTL+C closes bbackupquery console window under Windows n 70 ben bbackupd Non-ascii character cause error for notifyscript path n 71 ben bbackupd bbackupd.log gets randomly deleted n 72 test suite Patch intercept.h and intercept.c for NetBSD 4 and 5 n 74 bbackupquery Reconnect bbackupquery automatically, or at least have a "co n 75 ben bbackupd Restore times wrong, times on store correct n 77 ben bbackupd Min verbosity switch broken for bbackupquery a 78 chris bbackupd Error level for "bbackupquery.exe -u" 39 tickets total. From Kai.Liebenau at gmx.net Wed Oct 29 22:09:47 2014 From: Kai.Liebenau at gmx.net (Kai Liebenau) Date: Wed, 29 Oct 2014 23:09:47 +0100 Subject: [Boxbackup-dev] new Client in C# or VB.NET In-Reply-To: References: <53E64473.50908@gmx.net> Message-ID: <545165AB.4090306@gmx.net> Hi Chris, i have a new patch for WinNamedPipeStream. The definition for the Method Write ist bad, you have the underlining virtual Method from the IOStream changed. In the environment for MSVC 2010 i have a problem in the class BackupStoreCheck. In the Method CheckAndAddObject is an colision with the macros read and write of the emu.h file. Do you have any ideas? By the way, my Ctrl-C Handler works fine, but the GetLine::GetLineInternal generates an Exception GetLineEOF. I must search a solution for this. Cheers, Kai Am 10.08.2014 um 23:03 schrieb Chris Wilson: > Hi Kai, > > On Sat, 9 Aug 2014, Kai Liebenau wrote: > >> i come from germany and found the Box Backup for my raspberry PI. Is >> the development still in working? > > Yes, I am still working on it, but slowly. Other things have taken > most of my time for the last six months. > >> I am planning a client in VB.NET or C # to develop, which is more >> user friendly than the commandline.Is interest may be published >> provided it with in your SVN? > > Potentially yes, we have a contrib section: > > https://www.boxbackup.org/browser/box/trunk/contrib > > Please note that there are already a few GUIs, including Boxi and two > web interfaces. I think Charles Lecklider (copied) has also done some > work on a Windows GUI interface to Box Backup and may be able to > provide some assistance. > > Cheers, Chris. -------------- next part -------------- Index: WinNamedPipeStream.cpp =================================================================== --- WinNamedPipeStream.cpp (revision 3412) +++ WinNamedPipeStream.cpp (working copy) @@ -91,7 +91,7 @@ GetErrorMessage(err)); Close(); THROW_EXCEPTION(ConnectionException, - Conn_SocketReadError) + SocketReadError) } } } @@ -334,7 +334,7 @@ Close(); THROW_EXCEPTION(ConnectionException, - Conn_SocketReadError) + SocketReadError) } } } @@ -394,7 +394,7 @@ << GetErrorMessage(err)); Close(); THROW_EXCEPTION(ConnectionException, - Conn_SocketReadError) + SocketReadError) } } } @@ -424,7 +424,7 @@ BOX_ERROR("Failed to read from control socket: " << GetErrorMessage(err)); THROW_EXCEPTION(ConnectionException, - Conn_SocketReadError) + SocketReadError) } } @@ -446,7 +446,7 @@ // Created: 2003/07/31 // // -------------------------------------------------------------------------- -void WinNamedPipeStream::Write(const void *pBuffer, int NBytes) +void WinNamedPipeStream::Write(const void *pBuffer, int NBytes, int Timeout) { if (mSocketHandle == INVALID_HANDLE_VALUE || !mIsConnected) { @@ -486,7 +486,7 @@ Close(); THROW_EXCEPTION(ConnectionException, - Conn_SocketWriteError) + SocketWriteError) } NumBytesWrittenTotal += NumBytesWrittenThisTime; Index: WinNamedPipeStream.h =================================================================== --- WinNamedPipeStream.h (revision 3412) +++ WinNamedPipeStream.h (working copy) @@ -36,7 +36,8 @@ // both sides virtual int Read(void *pBuffer, int NBytes, int Timeout = IOStream::TimeOutInfinite); - virtual void Write(const void *pBuffer, int NBytes); + virtual void Write(const void *pBuffer, int NBytes, + int Timeout = IOStream::TimeOutInfinite); virtual void WriteAllBuffered(); virtual void Close(); virtual bool StreamDataLeft(); From chris+pine at qwirx.com Fri Oct 31 22:57:43 2014 From: chris+pine at qwirx.com (Chris Wilson) Date: Fri, 31 Oct 2014 22:57:43 +0000 (GMT) Subject: [Boxbackup-dev] current trunk In-Reply-To: <5436E390.9090107@gmx.net> References: <53E64473.50908@gmx.net> <5436E390.9090107@gmx.net> Message-ID: Hi Kai, First of all many thanks for the patches! And sorry for the delay in looking at them. I've been very busy these last few weeks, and also trying to solve a difficult problem with implementing snapshots. I haven't compiled on Windows for a while, because it's slow for me in a virtual machine, so I really appreciate you reporting and fixing issues. On Thu, 9 Oct 2014, Kai Liebenau wrote: > I missed the getopt.h file, but in the browser trunk tree is it present. I'm afraid I don't understand this one. Have you seen lib/win32/box_getopt.h which tries to determine whether to include bsd_getopt.h (included a copy from BSD) or getopt.h (which should be supplied by the system on Unix machines). So we shouldn't be including getopt.h directly, only box_getopt.h. Is that the problem? I can see two includes that might be wrong: lib/win32/emu.h:#include "getopt.h" lib/win32/getopt_long.cpp:#include "getopt.h" Did compilation fail on one of these? > Now then the WinNamedPipeStream.cpp file have some incorrect definition. > Here is the patch for them. > > In the file Daemon.cpp is missing one include for Win32. I have added > this and now i can compile it. I applied both of these, thank you! > For the ticket #69 "CRTL+C closes bbackupquery console window under > Windows", i have some modification. The current handler ignore the > Ctrl+C and Ctrl Colse Events. I don't knowing were i can interrupt the > current action. I can see where you're going but I don't really want to apply this patch as it is. We don't currently have a mechanism to interrupt an ongoing process in bbackupquery. Ctrl+C kills the process on both Unix and Windows. So this looks like a feature request, and one that might be a lot of work to implement. Apart from a global variable, I can't even see what kind of signalling it might need to use. Cheers, Chris. -- _____ __ _ \ __/ / ,__(_)_ | Chris Wilson Cambs UK | / (_/ ,\/ _/ /_ \ | Security/C/C++/Java/Ruby/Perl/SQL Developer | \__/_/_/_//_/___/ | We are GNU : free your mind & your software |