[Box Backup] testbbackupd.cpp

David H. Kaufman kaufman-box at kaufmanfamily.net
Fri Feb 18 21:41:22 GMT 2011


Hi all,

I couldn't find this in the bug database but maybe I just didn't know how to look. There's a 2-argument call to open in testbbackupd.cpp which wants to be 3-argument. This tripped me up compiling boxbackup for Ubuntu - I was surprised because I had not noticed that Gentoo is patching the test - and I guess the Gentoo patch didn't get reported upstream. The Gentoo patch is below, but I suspect that the new third argument ("700") is a typo for "0700".

--- a/test/bbackupd/testbbackupd.cpp    2010-05-01 15:52:27.000000000 +0200
+++ b/test/bbackupd/testbbackupd.cpp    2010-05-07 07:12:42.000000000 +0200
@@ -1176,7 +1176,7 @@
                std::string touchfile = 
                        "testfiles/TestDir1/spacetest/d1/touch-me";
 
-               fd = open(touchfile.c_str(), O_CREAT | O_WRONLY);
+               fd = open(touchfile.c_str(), O_CREAT | O_WRONLY, 700);
                TEST_THAT(fd > 0);
                // write again, to update the file's timestamp
                TEST_EQUAL_LINE(sizeof(buffer),


Regards,
David Kaufman



More information about the Boxbackup mailing list