[Box Backup] Unable to restore old versions of files...

Matto Marjanovic maddog at mir.com
Wed Jan 12 03:22:16 GMT 2011


On 01/08/11 21:10, Chris Wilson wrote:
> Hi Matto,
>
> On Thu, 9 Dec 2010, Matto Marjanovic wrote:
>> On 12/04/10 22:41, Matto Marjanovic wrote:
>>>
>>> Today I discovered that I can't restore old versions of files from
>>> backup (i.e. versions marked with the 'o' flag). Attempting to do
>>> so causes the server's connection child process to throw an exception:
>>
>> Okey-doke, a bit of poking around with gdb and I figured out what the
>> problem is: it is a bug in the handler for "get" command, inadvertently
>> introduced 4 years ago in revision 891.
>>
>> The problem is in the construction of the filename for a temporary file;
>> the buggy code loses a chunk of the path (due to an std::ostringstream
>> constructor not being used correctly). Whether or not the bug manifests
>> itself depends on the directory permissions of where the mis-filed file
>> ends up.
>>
>> Here is a patch that fixes the bug (which is still present in HEAD):
>
> I've applied your patch, it will be in 0.11.1, many thanks! And sorry for the inconvenience.

I'm honored, and you are welcome.
There was no data loss (the best kind of bug), so "All Is Forgiven".

-m



More information about the Boxbackup mailing list